From e105306a6f45a946e483133befadbcb2e03ec4f7 Mon Sep 17 00:00:00 2001 From: "andreas.dinauer" Date: Mon, 17 Nov 2025 21:06:53 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=8A=20Better=20logging?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- bruno/Get.bru | 8 +++---- bruno/Insert.bru | 4 +++- .../dev/dinauer/metrics/service/Resource.java | 13 +++++++++++- .../dinauer/metrics/service/utils/Timer.java | 21 +++++++++++++++++++ 4 files changed, 40 insertions(+), 6 deletions(-) create mode 100644 src/main/java/dev/dinauer/metrics/service/utils/Timer.java diff --git a/bruno/Get.bru b/bruno/Get.bru index 7a06429..9095403 100644 --- a/bruno/Get.bru +++ b/bruno/Get.bru @@ -5,18 +5,18 @@ meta { } get { - url: http://localhost:4000/api/metrics/POD-2/WORKLOAD?bucket-unit=DAILY + url: http://localhost:4000/api/metrics/analytics-backend-deployment-8695d9f87f-v8n7r/WORKLOAD?bucket-unit=RAW body: none auth: basic } params:query { - bucket-unit: DAILY + bucket-unit: RAW } auth:basic { - username: kubooboo - password: password + username: test + password: test } settings { diff --git a/bruno/Insert.bru b/bruno/Insert.bru index 56ff8b5..0aaaa01 100644 --- a/bruno/Insert.bru +++ b/bruno/Insert.bru @@ -26,7 +26,9 @@ body:json { "RELATIVE_CPU": "20", "RELATIVE_MEMORY": "23", "RELATIVE_DISK_USAGE": "56", - "TOTAL_DISK_SPACE": "73483209348" + "TOTAL_DISK_SPACE": "73483209348", + "REQUESTS": "2", + "AVERAGE_REQUESTS": "465" } } } diff --git a/src/main/java/dev/dinauer/metrics/service/Resource.java b/src/main/java/dev/dinauer/metrics/service/Resource.java index 4c769b1..fb48c57 100644 --- a/src/main/java/dev/dinauer/metrics/service/Resource.java +++ b/src/main/java/dev/dinauer/metrics/service/Resource.java @@ -6,13 +6,19 @@ import java.util.Optional; import jakarta.inject.Inject; import jakarta.ws.rs.*; +import org.jboss.logging.Logger; + import dev.dinauer.metrics.service.client.auth.AuthenticationService; import dev.dinauer.metrics.service.model.Bucket; import dev.dinauer.metrics.service.model.BucketUnit; +import dev.dinauer.metrics.service.utils.Timer; @Path("/{resource}/{metric}") public class Resource { + @Inject + Logger LOG; + @Inject AuthenticationService authenticationService; @@ -24,7 +30,9 @@ public class Resource { if (authenticationService.canWrite()) { + Timer timer = Timer.start(); service.index(resource, metric, insert.owner(), insert.values()); + LOG.infof("Indexing in %s seconds.", timer.stop()); } else { @@ -37,7 +45,10 @@ public class Resource { if (authenticationService.canRead()) { - return service.get(resource, metric, bucketUnit.orElse(BucketUnit.RAW)); + Timer timer = Timer.start(); + List buckets = service.get(resource, metric, bucketUnit.orElse(BucketUnit.RAW)); + LOG.infof("Retrieving %s buckets in %s seconds.", buckets.size(), timer.stop()); + return buckets; } else { diff --git a/src/main/java/dev/dinauer/metrics/service/utils/Timer.java b/src/main/java/dev/dinauer/metrics/service/utils/Timer.java new file mode 100644 index 0000000..961120b --- /dev/null +++ b/src/main/java/dev/dinauer/metrics/service/utils/Timer.java @@ -0,0 +1,21 @@ +package dev.dinauer.metrics.service.utils; + +public class Timer +{ + long start; + + public Timer() + { + this.start = System.nanoTime(); + } + + public static Timer start() + { + return new Timer(); + } + + public double stop() + { + return (System.nanoTime() - start) / 1_000_000_000.0; + } +}